feat(sdk-core): add execType to txrequest intent (CSHLD-972)#8972
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
feat(sdk-core): add execType to txrequest intent (CSHLD-972)#8972bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add ExecType enum (EXEC_UNSPECIFIED, EXEC_TRY) and wire it through
the intent layer so callers can set execType on txrequests.
The field flows from PrebuildTransactionOptions → IntentOptionsBase →
PopulatedIntentBase → the POST /wallet/{id}/txrequests body under
intent.execType, without introducing a top-level txrequest param.
Ticket: CSHLD-972
Session-Id: caa99360-6177-4227-8aba-5043f8cb453f
Task-Id: 49710c31-924d-41fb-b44b-2dc4a10bce34
bitgo-ai-agent-dev
Bot
force-pushed
the
sreeraj/cshld-972-exec-unspecified-intent
branch
from
a8d9d07 to
5cd582e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecTypeenum (EXEC_UNSPECIFIED,EXEC_TRY) tobaseTypes.ts, re-exported through the standard utils pathexecType?: ExecTypetoIntentOptionsBase(input) andPopulatedIntentBase(output), so it is inherited by all intent variantsexecTypefromPrebuildTransactionOptionsthroughpopulateIntentinmpcUtils.tsinto theintentobject sent toPOST /api/v2/wallet/{id}/txrequestsexecType: params.execTypein allprebuildTxWithIntentcall sites inwallet.tsThe field lands at
intent.execTypein the request body, not as a top-level txrequest param, which is what Figure Markets needs to defer execution viaEXEC_UNSPECIFIED.Test plan
tsc --noEmit)wallet.send*withexecType: ExecType.EXEC_UNSPECIFIEDand verify theintent.execTypefield is present in the outgoing request bodyTicket: CSHLD-972