Skip to content

native client listen does not call the wg.Done if the context is cancelled (prior to a DialConfig success). Here is code to resolve the problem. #145

Description

@daninmadison

In the listen function, the for loop checks for a ctx closed. If it is, it exits the function.
It needs to call the wg.Done.

If the Connect function is given a wrong details, the initial listen will never succeed the websocket.DialConfig.
As a result, the only way to stop this function is to cancel the context.
The problem is, the context closed does not call wg.Done prior to the return.

As a result, the Connect will be stuck at the wg.Wait and never return.

Here is code to correct the problem.

func (c *Client) listen(ctx context.Context, wg *sync.WaitGroup) {
var signalUp sync.Once

for {
	// Exit if our context has been closed
	if ctx.Err() != nil {
		if wg != nil {
			wg.Done()
		}
		return
	}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions