Skip to content

GPII-2404: Changed windows' display settings handler to retrieve all screen resolutions#121

Open
klown wants to merge 24 commits into
GPII:masterfrom
klown:GPII-2404
Open

GPII-2404: Changed windows' display settings handler to retrieve all screen resolutions#121
klown wants to merge 24 commits into
GPII:masterfrom
klown:GPII-2404

Conversation

@klown

@klown klown commented May 8, 2017

Copy link
Copy Markdown
Member

@kaspermarkus, @javihernandez

The modifiications to the window settings handler analogous to the linux pull request.

…creen resolutions

- Modified the display settings handler to get both the current and all available
screen resolutions in one JSON object.
- Refactored the handler into a fluid component.
- Updated the unit tests in light of the above.
@gpii-bot

gpii-bot commented May 8, 2017

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

…creen resolutions

Reverted getScreenResolution() to return an object with just width and height, but
modified getImpl() to add a "screen-resolution" property.
@gpii-bot

Copy link
Copy Markdown

CI job passed.

…resolutions

Better way to set current screen resolution return value.  Also, cleaned up some
comments.
@gpii-bot

Copy link
Copy Markdown

CI job passed.

@gpii-bot

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

klown commented Jun 26, 2017

Copy link
Copy Markdown
Member Author

@amatas, according to the console log, the VM creation timed out. No tests were run. Any idea why?

@amatas

amatas commented Jun 27, 2017

Copy link
Copy Markdown

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job passed.

@amatas

amatas commented Jun 27, 2017

Copy link
Copy Markdown

@klown sorry but seems that the creation of the VM took so much time to install some things that the Jenkins aborted the task. Perhaps it was because the host was very busy with other tasks. Now the tests passed.

@klown

klown commented Jun 27, 2017

Copy link
Copy Markdown
Member Author

@amatas no problem -- it's not your fault. Thanks for re-running it!

@gpii-bot

gpii-bot commented Jul 5, 2017

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

klown commented Jul 12, 2017

Copy link
Copy Markdown
Member Author

@amatas Tapping your shoulder...

@amatas

amatas commented Jul 12, 2017

Copy link
Copy Markdown

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@klown

klown commented Jul 12, 2017

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job passed.

@gpii-bot

gpii-bot commented Aug 4, 2017

Copy link
Copy Markdown

CI job passed.

@gpii-bot

Copy link
Copy Markdown

CI job passed.

@gpii-bot

Copy link
Copy Markdown

CI job passed.

Modifed the "getAllScreenResolutions" to drop the "dmPels" prefix.
@gpii-bot

Copy link
Copy Markdown

CI job passed.

@gpii-bot

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/389/

@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/393/

@klown

klown commented Feb 20, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/395/

Merge upstream master GPII windows branch into GPII-2404.
@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/415/

@klown

klown commented Mar 12, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/417/

@gpii-bot

gpii-bot commented Apr 2, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/444/

@klown

klown commented Apr 5, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

gpii-bot commented Apr 5, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/452/

@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/469/

@klown

klown commented Apr 25, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/470/

@gpii-bot

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/493/

@klown

klown commented Jun 4, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

gpii-bot commented Jun 4, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/512/

@klown

klown commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

gpii-bot commented Jun 5, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/519/

@klown

klown commented Jun 6, 2018

Copy link
Copy Markdown
Member Author

ok to test

@gpii-bot

gpii-bot commented Jun 6, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/522/

@gpii-bot

gpii-bot commented Jun 7, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/527/

@gpii-bot

gpii-bot commented Jun 8, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/windows-tests/532/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants