Fix double-negative error message in TransferFunction call#1061
Merged
Conversation
The discrete-only call methods for TransferFunction threw an ArgumentError with the message "It only makes no sense to call this function with discrete systems" — a double negative that asserts the opposite of the actual requirement. Rephrase to "This function can only be called with discrete-time systems". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This is an automated message.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 42 42
Lines 5653 5653
=======================================
Hits 5179 5179
Misses 474 474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The discrete-only call methods for
TransferFunctionthrewArgumentError("It only makes no sense to call this function with discrete systems")— a double negative whose plain reading is the opposite of the actual requirement.Rephrase to
"This function can only be called with discrete-time systems". Logic unchanged.Test plan
tf(1,[1,1])(0.5, false)(continuous) and confirm the message is the new wording.🤖 Generated with Claude Code