Render daemonsets.podSecurityContext in Helm ClusterPolicy template - #2703
Open
kbix2000 wants to merge 1 commit into
Open
Render daemonsets.podSecurityContext in Helm ClusterPolicy template#2703kbix2000 wants to merge 1 commit into
kbix2000 wants to merge 1 commit into
Conversation
The CRD and controller already honor spec.daemonsets.podSecurityContext, but the Helm chart never forwarded the values field into ClusterPolicy.
kbix2000
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
July 31, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render ClusterPolicy daemonsets.podSecurityContext from Helm values
Problem
ClusterPolicy.spec.daemonsets.podSecurityContextis already supported by the CRD and by the operator controller (applyCommonDaemonsetConfig). Helm values such as:were silently ignored because
deployments/gpu-operator/templates/clusterpolicy.yamlnever emitted the field.This breaks SELinux / OpenShift-style deployments that rely on chart values alone (no manual ClusterPolicy edit).
Change
daemonsets.podSecurityContextinto the ClusterPolicy when set in values.values.yaml.Follow-up request
Global
daemonsets.podSecurityContextapplies to all operand DaemonSets. We would also like optional per-operandpodSecurityContext(e.g. underdriver,toolkit,devicePlugin) so SELinux types can be scoped without granting every DaemonSet the same domain. Happy to follow up in a separate PR if preferred.Test plan
helm templatewithdaemonsets.podSecurityContext.seLinuxOptionsset → ClusterPolicy includes the field underspec.daemonsetshelm templatewithout the value → field absent