Is this a regression?
Yes
Severity
π‘ Minor β small but noticeable issue
Please provide the branch(es) you discovered this issue in
v100
Environment Details
Node 22.22, Windows Server 2019
Please provide a minimal set of steps to reproduce the issue
Repro steps:
- Install Node 22.22
- In Windows, create a directory called "One Identity Angular" and clone the imx repo
- Change to imxweb and run "npm install"
Description
Result:
Running command npm i @elemental-ui/cadence-icon@C:\One Identity\angular-v10\IdentityManager.Imx\imxweb\imx-modules\cadence-icon-3.1.111.tgz @elemental-ui/core@C:\One Identity\angular-v10\IdentityManager.Imx\imxweb\imx-modules\elemental-ui-core-20.0.76.tgz @imx-modules/imx-api-aad@C:\One Identity\angular-v10\IdentityManager.Imx\imxweb\imx-modules\imx-api-aad.tgz @imx-modules/imx-api-aob@C:\One Identity\angular-v10\IdentityManager.Imx\imxweb\imx-modules\imx-api-aob.tgz @imx-modules/imx-api-apc@C:\One Identity\angular-
...
'npm warn tarball tarball data for file:Identity/angular-v10/IdentityManager.Imx/imxweb/imx-modules/cadence-icon-3.1.111.tgz (null) seems to be corrupted. Trying again.\n' +
Describe what you expected to happen versus what actually happened
Notes:
The issue appears to be in imxweb\scripts\install-local-package.ts in the V100 branch. When installArg is built in lines 102-106, The filePath is not enclosed in quotation marks or escaped. The result is that the directory with a space is split and considered separate arguments to the npm command. I fixed this by putting a double quote around filePath but maybe there is a more elegant solution:
if (file.includes('imx-')) {
const baseName = path.parse(file).name;
installArg += [nodePackageDir, '/', baseName, '@"', filePath, '" '].join('');
Relevant logs or console output
Add a screenshot(s) if that helps illustrate the problem
No response
Suggested Fix
No response
Anything else?
No response
Before submitting...
Is this a regression?
Yes
Severity
π‘ Minor β small but noticeable issue
Please provide the branch(es) you discovered this issue in
v100
Environment Details
Node 22.22, Windows Server 2019
Please provide a minimal set of steps to reproduce the issue
Repro steps:
Description
Result:
Describe what you expected to happen versus what actually happened
Notes:
The issue appears to be in imxweb\scripts\install-local-package.ts in the V100 branch. When installArg is built in lines 102-106, The filePath is not enclosed in quotation marks or escaped. The result is that the directory with a space is split and considered separate arguments to the npm command. I fixed this by putting a double quote around filePath but maybe there is a more elegant solution:
Relevant logs or console output
Add a screenshot(s) if that helps illustrate the problem
No response
Suggested Fix
No response
Anything else?
No response
Before submitting...