ci: pin claude-code-action to a SHA in claude-code-review.yml - #80
Merged
jnasbyupgrade merged 1 commit intoSep 8, 2026
Merged
Conversation
Same fix, same rationale as pgxntool commit db659c2: this job runs as pull_request_target with pull-requests: write, so a moved upstream tag must not silently change what code runs -- matching the SHA-pin already used for github-script in pgxntool's ci.yml/protect-label.yml. claude-code-action was the one action in this trust class still tracking a mutable tag (@v1). `actions/checkout` here and claude.yml's own claude-code-action@v1 stay on tags deliberately (existing comments: "so upstream fixes are picked up automatically") -- this doesn't touch either. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
September 8, 2026 20:31
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Sep 8, 2026
- `claude-code-review.yml`'s job runs as `pull_request_target` with
`pull-requests: write`, so a moved upstream tag must not silently change
what code runs -- the same reasoning already applied to
`github-script`'s SHA pin in `ci.yml`/`protect-label.yml` (see those
comments). `claude-code-action` was the one action in this trust class
still tracking a mutable tag (`@v1`) instead of a SHA.
- `actions/checkout` (here and elsewhere) and `claude.yml`'s own
`claude-code-action@v1` stay on tags deliberately -- existing comments
already explain why ("so upstream fixes are picked up automatically");
`checkout` only reads the base branch, and `claude.yml` runs under a
narrower trust boundary (actor-gated, read-only permissions), not
`pull_request_target` with write access. This PR doesn't touch either.
Companion pgxntool-test PR:
Postgres-Extensions/pgxntool-test#80
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#112
Summary
pull_request_targetwithpull-requests: write, so a moved upstream tag must not silently change what code runs -- matching the SHA pin already used forgithub-scriptin pgxntool'sci.yml/protect-label.yml.claude-code-actionwas the one action in this trust class still tracking a mutable tag (@v1).actions/checkouthere andclaude.yml's ownclaude-code-action@v1stay on tags deliberately (existing comments explain why); this PR doesn't touch either.