Skip to content

Atomizer tests assert list.sort() == list.sort() (compares None == None) #69

@wshlavacek

Description

@wshlavacek

tests/test_bng_atomizer.py has two assertions of the form list.sort() == list.sort(). list.sort() returns None, so both sides are always None and the assertion passes regardless of the actual file listing.

Locations:

  • tests/test_bng_atomizer.py:23 (in test_atomize_flat)
  • tests/test_bng_atomizer.py:42 (in test_atomize_atomized)

Fix is assert sorted(file_list) == sorted(to_match). Note that the test output directory tests/test/ is reused across runs, so once the assertion is real, switching to a per-test tmp_path (or cleaning the directory at setup) is also likely needed.

Supersedes #68 (which is reachable by direct URL but does not appear in the repo issues list).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions