Replace deprecated around_filter with around_action in README - #631
Open
jimmyasyraf wants to merge 1 commit into
Open
Replace deprecated around_filter with around_action in README#631jimmyasyraf wants to merge 1 commit into
jimmyasyraf wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only change: updates the memoized cache proxy example in the README to use
around_actioninstead ofaround_filter.Why
The
*_filtercallback names were deprecated in Rails 5.0 and removed entirely in Rails 5.1 (2017). Copying the current README example into any modern Rails app raises:around_actionis the direct replacement (it was introduced as an alias in Rails 4.0 and has been the canonical name since), so the example now works on all Rails versions this gem supports.No behavior change —
with_memoizationitself is untouched.