Branch hint fuzz bug with --code-pushing

[tlively]

repro.zip

$ ./repro.sh
+ bin/wasm-opt -all b.wast -S -o b.inst.wast --randomize-branch-hints --instrument-branch-hints -g
+ bin/wasm-opt -all b.inst.wast --fuzz-exec-before
[fuzz-exec] export test
[LoggingExternalInterface log-branch 1 1 0]
[LoggingExternalInterface logging 0]
[LoggingExternalInterface log-branch 2 1 1]
warning: no passes specified, not doing any work
warning: no output file specified, not emitting output
+ bin/wasm-opt -all b.inst.wast -S -o b.de_inst.wast --delete-branch-hints=1 --deinstrument-branch-hints -g
+ bin/wasm-opt -all b.de_inst.wast -S -o b.opted.wast -g --code-pushing
+ bin/wasm-opt -all b.opted.wast -S -o b.final.wast --instrument-branch-hints -g
+ bin/wasm-opt -all b.final.wast --fuzz-exec-before
[fuzz-exec] export test
[LoggingExternalInterface logging 0]
[LoggingExternalInterface log-branch 1 1 1]
warning: no passes specified, not doing any work
warning: no output file specified, not emitting output

So it looks like branch hint number 1 changed results, but looking at the original instrumentation and the final instrumentation, it's maybe a completely different branch??? Not really sure what the correct next step is.

[kripken]

Does #8613 fix it for you?

[tlively]

Ah, I should have looked at the open PRs :)