Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

FindCredentials call on Linux without unlocking the key store crashes #477

@jsimonet

Description

@jsimonet

Prerequisites

Some prerequisites are not applicable since I did not used Atom to develop the fix and check for testing.

Description

FindCredentials call on Linux without unlocking the key store crashes.

  (process:280213): libsecret-CRITICAL **: 16:09:20.426: secret_value_get_text: assertion 'value' failed

Steps to Reproduce

  1. Ensure the key store is locked
  2. call FindCredentials
  3. Click on "Cancel" when password is asked for unlocking the keystore

Expected behavior:

A crash does not happens.

Actual behavior:

A crash does happens.

Reproduces how often:

100% of the time.

Versions

Not using Atom for testing, using another Electron application.

Linux Manjaro Release: 22.0.0.

Additional Information

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions