Skip to content

Parse settings mutate defined objects as argument #44

Description

@colbyfayock

If I create a predefined object for the second argument, it would be mutated unexpectedly by the second time I invoke parse.

For instance:

const GEOJSON_PARSE_SETTINGS = {
  'Point': [
    'x',
    'y'
  ],
  'LineString': 'line',
  'Polygon': 'polygon'
};
return GeoJSON.parse(data, GEOJSON_PARSE_SETTINGS);

First time around it works, however the second time around, after being invoked, the object getting passed in there is actually:

{doThrows: {…}, geom: {…}} // GEOJSON_PARSE_SETTINGS output

This of course is avoidable by spreading it or cloning it, but just found it unexpected.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions