Skip to content

Feature/load new lifecycle config#208

Open
NicolasFussberger wants to merge 40 commits into
eclipse-score:mainfrom
etas-contrib:feature/load-new-lifecycle-config
Open

Feature/load new lifecycle config#208
NicolasFussberger wants to merge 40 commits into
eclipse-score:mainfrom
etas-contrib:feature/load-new-lifecycle-config

Conversation

@NicolasFussberger

@NicolasFussberger NicolasFussberger commented May 19, 2026

Copy link
Copy Markdown
Contributor
  • Introduces an interface in src/launch_manager_daemon/config for loading a launch manager configuration file
  • Introduce an implementation of this interface using flatbuffer
  • Introduce unit tests for the new code

Note: The code is not actually in use yet. The python script which does the translation from the user-facing json configuration to the flatbuffer json format is not part of the PR and will be added in a follow up PR.
Furthermore, the launch manager code needs to be adapted to use the new structure.

Background:

  • In the last months we had defined a new user-facing configuration format (see src/launch_manager_daemon/config/config_schema/launch_manager.schema.json).
  • However, this new format is currently still mapped to the old configuration files (to processes / process groups). So the code is not actually reading the new configuration file

Relates To: #209

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: dbe514ef-5cd4-464b-b8cf-d8abba6dc831
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (30 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2720 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4629 targets configured)

Analyzing: target //:license-check (151 packages loaded, 8079 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (159 packages loaded, 8254 targets configured)

INFO: Analyzed target //:license-check (163 packages loaded, 10268 targets configured).
[10 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions running)
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.912s, Critical Path: 2.63s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread MODULE.bazel Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/config.hpp
Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
Comment thread MODULE.bazel Outdated
Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
@paulquiring

Copy link
Copy Markdown
Contributor

review from my side is finished.

Comment thread src/launch_manager_daemon/config/src/flatbuffer_config_loader.cpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread src/launch_manager_daemon/config/include/config.hpp Outdated
Comment thread score/launch_manager/daemon/src/configuration/config/BUILD Outdated
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

#load("@score_baselibs//score/flatbuffers/bazel:codegen.bzl", "generate_cpp")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is everything commented out in this BUILD file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this file got in by rebasing after the folder restructure. Removed now in 39f9616

Comment thread score/launch_manager/daemon/src/configuration/details/config.cpp
template <typename TargetT>
score::cpp::expected<TargetT, IConfigLoader::Error> validateRange(uint32_t value, const char* field_name)
{
if (value < static_cast<uint32_t>(std::numeric_limits<TargetT>::min()) ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work as intended.
https://godbolt.org/z/8qhaG8hEz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants