Skip to content

Per-button repeat attribute inconsistency and repeat limit (For long-press simulation) #762

Description

@MarcMartinn

Hi,

I found a few inconsistencies regarding the repeat attribute.

The global Repeat option works correctly with both WINLIRC_NEC1 and WINLIRC_RAW.
However, the XML attribute repeat="x" on an individual <button> works only with WINLIRC_NEC1. In WINLIRC_RAW, it is ignored.
The UI limits the Repeat value to 9, while manually editing the XML allows values up to 18.
Any value above 18 makes the button stop working.

Feature requests:

Support the repeat attribute on individual WINLIRC_RAW buttons, just like WINLIRC_NEC1.
Remove (or significantly increase) the current repeat limit in both the UI and the XML parser, so users can choose the repeat count they need.

This would make long-press simulation much easier and would avoid creating very large macros.

Thank you for your work on IrPlus.

Edit: Example, for an individual button, this one works, but it is limited to 'repeat="18"' with 'WINLIRC_NEC1' for button label &#1044549;&#10;Appui long&#10;POWER/MODE: https://drive.google.com/file/d/1FL95Ov31SJ2gNFaCpaOykcLsEXGp10wW/view?usp=sharing

<irplus>
 <device manufacturer="Radiateur &#224; panneau rayonnant SilverCrest" model="75784" columns="6" format="WINLIRC_NEC1" bits="16" pre-bits="16" scaleRatio="1.1">
  <space multiple="8" />
  <space multiple="8" />
  <button label="AUTO ON" labelSize="50.0" span="8">0x00ff 0xa25d</button>
  <space multiple="6" />
  <button label="&#1045367;" labelSize="60.0" span="2" backgroundColor="FF000000">0x00ff 0xe01f</button>
  <button label="POWER/MODE" labelSize="25.0" span="2" backgroundColor="FF2D0000">0x00ff 0xa857</button>
  <button label="&#1045529;" labelSize="60.0" span="2" backgroundColor="FF000000">0xFF 0x906F</button>
  <button label="&#1044549;&#10;Appui long&#10;POWER/MODE" labelSize="25.0" span="8" repeat="18" backgroundColor="FF2D0000">0x00ff 0xa857</button>
  <space multiple="6" />
  <button label="AUTO OFF" labelSize="50.0" span="8">0x00ff 0x18E7</button>
 </device>
</irplus>

And this one, 'repeat="18"', is completely ignored with 'WINLIRC_RAW' for button label &#1045604;: https://drive.google.com/file/d/1arlXi2sCx9tkm56WzezUA0x-Rk2lxeWN/view?usp=sharing

<irplus>
 <device manufacturer="Ventilateur BIONAIRE" model="BT19" columns="1" format="WINLIRC_RAW" scaleRatio="2.0">
  <space multiple="1" />
  <button label="&#61457;" labelSize="49.0" span="1" labelColor="FFFF2D28" backgroundColor="FFD9E1E3">1300 350 1300 400 450 1200 1300 350 1350 350 450 1200 500 1200 450 1200 450 1200 500 1200 1300 350 450</button>
  <button label="&#1045008;" labelSize="49.0" span="4" labelColor="FF474CFF" backgroundColor="FFD9E1E3">1250 400 1300 350 450 1250 1250 400 1250 400 450 1250 450 1200 450 1200 450 1250 1250 400 450 1250 400</button>
  <button label="&#1045604;" labelSize="49.0" span="4" repeat="18" labelColor="FF474CFF" backgroundColor="FFD9E1E3">1250 400 1300 350 450 1250 1250 400 1250 400 450 1250 450 1200 450 1200 450 1250 1250 400 450 1250 400</button>
  <button label="&#1044512;" labelSize="49.0" span="4" labelColor="FF333333" backgroundColor="FFD9E1E3">1300 400 1250 400 400 1300 1250 400 1250 400 450 1250 400 1250 400 1250 1250 450 400 1250 400 1250 450</button>
  <button label="&#1045917;/&#1045682;" labelSize="49.0" span="4" labelColor="FF00A8FF" backgroundColor="FFD9E1E3">1250 400 1250 450 400 1250 1250 450 1200 450 400 1250 400 1250 1250 450 400 1250 400 1250 450 1200 450</button>
 </device>
</irplus>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions