Skip to content

Not all commits being added to main are checked during PR #2176

@gregfurman

Description

@gregfurman

Describe the issue

It is currently possible to have commits prior to HEAD of an incoming branch merged into main that contain vulnerabilities

minder seemingly does not evaluate all commits in a diff allowing for a commit with a vulnerable version to be included when merging a PR.

Although this wont cause HEAD of main (or the target) to have a vulnerability pulled in, there should be checks against being able to introduce any commits onto main that include unsafe dependencies.

To Reproduce

  • Create a branch off of main
  • Change a dependency's version to include a vulnerability and commit (commit A)
  • Change this dependency back to a safe version in a new commit (commit B)
  • Create a PR and see how minder will evaluate this as safe despite commit A being present and potentially introducing a vulnerability to the version history

What version are you using?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Nice to fix: non-critical items that should be evaluated and planned during issue triagebugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions