Commit 409f114
committed
Fix maintainVisibleContentPosition with rapid data updates (#53542)
Fixes #53542 where rapid prepends with coalesced native scroll events leave pendingScrollUpdateCount stuck, freezing render window.
Root cause: pendingScrollUpdateCount increments by 1 per prepend (0->1->2) but EventQueue coalesces N scroll events into 1 via dispatchUniqueEvent (ScrollViewEventEmitter.cpp:13 + EventQueue.cpp:29-50 replaces in place), so single scroll drains 2->1 leaving blocked. Also leak when JS predicate fires but native declines (tag recycled, delta<=0.5, clamped).
Fix: Clamp pending to 1 (not accumulate) and drain to 0 on any scroll, so single coalesced event unblocks. Prevents frozen window, suppressed onViewableItemsChanged and onEndReached.
[GENERAL] [FIXED] - Fix maintainVisibleContentPosition with rapid data updates (#53542)1 parent 0927347 commit 409f114
2 files changed
Lines changed: 79 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
777 | 777 | | |
778 | 778 | | |
779 | 779 | | |
780 | | - | |
| 780 | + | |
781 | 781 | | |
782 | 782 | | |
783 | 783 | | |
| |||
1760 | 1760 | | |
1761 | 1761 | | |
1762 | 1762 | | |
1763 | | - | |
1764 | | - | |
1765 | | - | |
| 1763 | + | |
1766 | 1764 | | |
1767 | 1765 | | |
1768 | 1766 | | |
| |||
Lines changed: 77 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2877 | 2877 | | |
2878 | 2878 | | |
2879 | 2879 | | |
| 2880 | + | |
| 2881 | + | |
| 2882 | + | |
| 2883 | + | |
| 2884 | + | |
| 2885 | + | |
| 2886 | + | |
| 2887 | + | |
| 2888 | + | |
| 2889 | + | |
| 2890 | + | |
| 2891 | + | |
| 2892 | + | |
| 2893 | + | |
| 2894 | + | |
| 2895 | + | |
| 2896 | + | |
| 2897 | + | |
| 2898 | + | |
| 2899 | + | |
| 2900 | + | |
| 2901 | + | |
| 2902 | + | |
| 2903 | + | |
| 2904 | + | |
| 2905 | + | |
| 2906 | + | |
| 2907 | + | |
| 2908 | + | |
| 2909 | + | |
| 2910 | + | |
| 2911 | + | |
| 2912 | + | |
| 2913 | + | |
| 2914 | + | |
| 2915 | + | |
| 2916 | + | |
| 2917 | + | |
| 2918 | + | |
| 2919 | + | |
| 2920 | + | |
| 2921 | + | |
| 2922 | + | |
| 2923 | + | |
| 2924 | + | |
| 2925 | + | |
| 2926 | + | |
| 2927 | + | |
| 2928 | + | |
| 2929 | + | |
| 2930 | + | |
| 2931 | + | |
| 2932 | + | |
| 2933 | + | |
| 2934 | + | |
| 2935 | + | |
| 2936 | + | |
| 2937 | + | |
| 2938 | + | |
| 2939 | + | |
| 2940 | + | |
| 2941 | + | |
| 2942 | + | |
| 2943 | + | |
| 2944 | + | |
| 2945 | + | |
| 2946 | + | |
| 2947 | + | |
| 2948 | + | |
| 2949 | + | |
| 2950 | + | |
| 2951 | + | |
| 2952 | + | |
| 2953 | + | |
| 2954 | + | |
| 2955 | + | |
| 2956 | + | |
2880 | 2957 | | |
2881 | 2958 | | |
2882 | 2959 | | |
| |||
0 commit comments