Skip to content

Commit 73d69c0

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Cover 'react/performance' subtree with C++ stable API guards (#57320)
Summary: Adds private guards to `react/performance/timeline:timeline` and `react/performance/cdpmetrics:cdpmetrics` headers preventing from inclusions when `RN_STABLE_API` is turned on. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D109558177
1 parent 5a29c68 commit 73d69c0

16 files changed

Lines changed: 30 additions & 0 deletions

packages/react-native/ReactCommon/react/performance/cdpmetrics/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ target_include_directories(react_performance_cdpmetrics PUBLIC ${REACT_COMMON_DI
1818
target_link_libraries(react_performance_cdpmetrics
1919
folly_runtime
2020
jsi
21+
react_cxxstableapi
2122
react_performance_timeline
2223
react_timing
2324
runtimeexecutor)

packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <string_view>
1113
#include <unordered_map>
1214

packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpMetricsReporter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <ReactCommon/RuntimeExecutor.h>
1113
#include <jsi/jsi.h>
1214
#include <react/performance/timeline/PerformanceEntry.h>

packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <ReactCommon/RuntimeExecutor.h>
1113
#include <jsi/jsi.h>
1214
#include <react/performance/timeline/PerformanceEntry.h>

packages/react-native/ReactCommon/react/performance/cdpmetrics/React-performancecdpmetrics.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ Pod::Spec.new do |s|
4040

4141
resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancecdpmetrics")
4242

43+
s.dependency "React-cxxstableapi"
44+
4345
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
4446
s.dependency "React-jsi"
4547
s.dependency "React-performancetimeline"

packages/react-native/ReactCommon/react/performance/timeline/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ target_link_libraries(react_performance_timeline
1919
jsinspector
2020
jsinspector_tracing
2121
reactperflogger
22+
react_cxxstableapi
2223
react_featureflags
2324
react_timing
2425
folly_runtime)

packages/react-native/ReactCommon/react/performance/timeline/CircularBuffer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <algorithm>
1113
#include <functional>
1214
#include <vector>

packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntry.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <react/timing/primitives.h>
1113

1214
#include <optional>

packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryBuffer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <vector>
1113
#include "PerformanceEntry.h"
1214

packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryCircularBuffer.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include "CircularBuffer.h"
1113
#include "PerformanceEntryBuffer.h"
1214

0 commit comments

Comments
 (0)