Skip to content

Commit e8152d4

Browse files
coadometa-codesync[bot]
authored andcommitted
Add stable API guards to text and textinput components (#57363)
Summary: Pull Request resolved: #57363 This diff rolls umbrella guards for `react/renderer/components/text` and `react/renderer/components/textinput`. Initially, we consider `text` component target as `public` and `textinput` as `for frameworks`, so the umbrella is added only to the `text` target. Changelog: [Internal] Differential Revision: D109849283
1 parent 5988c9e commit e8152d4

46 files changed

Lines changed: 150 additions & 0 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,10 @@ val preparePrefab by
195195
"../ReactCommon/react/renderer/components/text/",
196196
"react/renderer/components/text/",
197197
),
198+
Pair(
199+
"../ReactCommon/react/renderer/components/text/React/",
200+
"React/",
201+
),
198202
Pair(
199203
"../ReactCommon/react/renderer/attributedstring",
200204
"react/renderer/attributedstring",

packages/react-native/ReactCommon/React-FabricComponents.podspec

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ Pod::Spec.new do |s|
6060
s.dependency "React-logger"
6161
s.dependency "React-Core"
6262
s.dependency "React-debug"
63+
s.dependency "React-cxxstableapi"
6364
s.dependency "React-featureflags"
6465
s.dependency "React-utils"
6566
s.dependency "React-runtimescheduler"
@@ -109,6 +110,12 @@ Pod::Spec.new do |s|
109110
sss.header_dir = "react/renderer/components/text"
110111
end
111112

113+
ss.subspec "textUmbrella" do |sss|
114+
sss.source_files = "react/renderer/components/text/React/*.h"
115+
sss.header_dir = "React"
116+
sss.header_mappings_dir = "react/renderer/components/text/React"
117+
end
118+
112119
ss.subspec "iostextinput" do |sss|
113120
sss.source_files = podspec_sources(["react/renderer/components/textinput/*.{m,mm,cpp,h}",
114121
"react/renderer/components/textinput/platform/ios/**/*.{m,mm,cpp,h}"],

packages/react-native/ReactCommon/react/renderer/components/text/BaseParagraphComponentDescriptor.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/core/ConcreteComponentDescriptor.h>
1113
#include <react/renderer/textlayoutmanager/TextLayoutManager.h>
1214
#include <react/utils/ContextContainer.h>

packages/react-native/ReactCommon/react/renderer/components/text/BaseParagraphProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <limits>
1113
#include <memory>
1214

packages/react-native/ReactCommon/react/renderer/components/text/BaseTextProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/attributedstring/TextAttributes.h>
1113
#include <react/renderer/core/Props.h>
1214
#include <react/renderer/core/PropsParserContext.h>

packages/react-native/ReactCommon/react/renderer/components/text/BaseTextShadowNode.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/attributedstring/AttributedString.h>
1113
#include <react/renderer/attributedstring/TextAttributes.h>
1214

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphComponentDescriptor.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/text/BaseParagraphComponentDescriptor.h>
1113
#include <react/renderer/components/text/ParagraphShadowNode.h>
1214

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphEventEmitter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/view/ViewEventEmitter.h>
1113
#include <react/renderer/textlayoutmanager/TextMeasureCache.h>
1214

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/text/HostPlatformParagraphProps.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphShadowNode.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/components/text/BaseTextShadowNode.h>
1113
#include <react/renderer/components/text/ParagraphEventEmitter.h>
1214
#include <react/renderer/components/text/ParagraphProps.h>

0 commit comments

Comments
 (0)