Drop RCT_EXPORT_METHOD from RCTTestModule TurboModule - #58095
Closed
christophpurrer wants to merge 1 commit into
Closed
Drop RCT_EXPORT_METHOD from RCTTestModule TurboModule#58095christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
Summary: `RCTTestModule` is a TurboModule: it conforms to `NativeTestModuleSpec` and returns `NativeTestModuleSpecJSI` from `getTurboModule:`, so JS->ObjC dispatch is driven by codegen, not by `RCT_EXPORT_METHOD`'s `__rct_export__` metadata. The macro is dead weight. Convert the three spec-declared methods to plain ObjC declarations; conformance to `NativeTestModuleSpec` keeps their signatures compiler-enforced. ``` - (void)markTestCompleted; - (void)markTestPassed:(BOOL)success; - (void)verifySnapshot:(RCTResponseSenderBlock)callback; ``` `sendAppEvent:body:` keeps its macro because it is not declared in the spec protocol, and the two `RCT_REMAP_METHOD` exports keep theirs because they define custom JS names. Changelog: [Internal] Differential Revision: D117201272
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117201272. |
|
This pull request has been merged in 21f0889. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTTestModuleis a TurboModule: it conforms toNativeTestModuleSpecand returnsNativeTestModuleSpecJSIfromgetTurboModule:, so JS->ObjC dispatch is driven bycodegen, not by
RCT_EXPORT_METHOD's__rct_export__metadata. The macro is dead weight.Convert the three spec-declared methods to plain ObjC declarations; conformance to
NativeTestModuleSpeckeeps their signatures compiler-enforced.sendAppEvent:body:keeps its macro because it is not declared in the spec protocol, andthe two
RCT_REMAP_METHODexports keep theirs because they define custom JS names.Changelog: [Internal]
Differential Revision: D117201272