From 74fdd86fdeb35b81b37c1aee70af9efa93df7730 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Sun, 23 Aug 2026 23:38:35 -0700 Subject: [PATCH 1/2] Cover `jsinspector-modern/tracing:profile` with Stable API guards (#57977) Summary: Classifies `jsinspector-modern/tracing:profile` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its headers directly; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D116294338 --- .../ReactCommon/jsinspector-modern/tracing/CMakeLists.txt | 1 + .../ReactCommon/jsinspector-modern/tracing/ProfileTreeNode.h | 2 ++ .../jsinspector-modern/tracing/React-jsinspectortracing.podspec | 1 + .../ReactCommon/jsinspector-modern/tracing/TraceEventProfile.h | 2 ++ 4 files changed, 6 insertions(+) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/tracing/CMakeLists.txt index f0c7cd063c41..0746764c8b59 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/CMakeLists.txt +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/CMakeLists.txt @@ -21,6 +21,7 @@ target_link_libraries(jsinspector_tracing jsi jsinspector_network oscompat + react_cxxstableapi react_timing react_utils ) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/ProfileTreeNode.h b/packages/react-native/ReactCommon/jsinspector-modern/tracing/ProfileTreeNode.h index 78736b065a3e..5efd0d022784 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/ProfileTreeNode.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/ProfileTreeNode.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec b/packages/react-native/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec index 455d12c8fdef..af960c453a2c 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/React-jsinspectortracing.podspec @@ -44,6 +44,7 @@ Pod::Spec.new do |s| resolve_use_frameworks(s, header_mappings_dir: "../..", module_name: module_name) add_dependency(s, "React-jsinspectornetwork", :framework_name => 'jsinspector_modernnetwork') + s.dependency "React-cxxstableapi" s.dependency "React-jsi" s.dependency "React-oscompat" s.dependency "React-timing" diff --git a/packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventProfile.h b/packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventProfile.h index 0d054dade0fe..0b49bc05ba4c 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventProfile.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/tracing/TraceEventProfile.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include From ebead3a0c38253f1718e428d35a07997e8f62ca1 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Sun, 23 Aug 2026 23:38:35 -0700 Subject: [PATCH 2/2] Cover `jsinspector-modern/cdp:jsinspector_cdp` with Stable API guards (#58042) Summary: Classifies `jsinspector-modern/cdp:jsinspector_cdp` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D116917710 --- .../ReactCommon/jsinspector-modern/cdp/CMakeLists.txt | 1 + .../react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h | 2 ++ .../jsinspector-modern/cdp/React-jsinspectorcdp.podspec | 2 ++ 3 files changed, 5 insertions(+) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt index 0931f76246fb..43c0637dbf89 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt @@ -23,4 +23,5 @@ target_include_directories(jsinspector_cdp PUBLIC ${REACT_COMMON_DIR}) target_link_libraries(jsinspector_cdp folly_runtime + react_cxxstableapi ) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h index 89576d96295b..6a0fd5cc6960 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec b/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec index 8a7eaf0496d1..238487ff4cad 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec @@ -46,5 +46,7 @@ Pod::Spec.new do |s| add_rn_third_party_dependencies(s) add_rncore_dependency(s) + s.dependency "React-cxxstableapi" + mark_as_react_native_build(s) end