BinaryParser.fromLong loops and runs out of memory on negative numbers

[calvinfo]

Seems to be the way it is bit shifting in encodeInt after adjusting data to be represented as a positive number.

To reproduce:

thrift.BinaryParser.BinaryParser.fromLong(-1);

FATAL ERROR: CALL_AND_RETRY_0 Allocation failed - process out of memory.

[calvinfo]

Ah figured out more of the problem. Javascript doesn't have adequate precision for numbers that large, try Math.pow(2, 64) - 1 === Math.pow(2, 64) from node and you'll see what I mean.

The array is then initialized to 9 bytes instead of 8, resulting in an infinite loop in the encodeInt function.

[devdazed]

Interesting, I will have a look into this