chore: add permission controls#12775
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca6ecb92f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div class="mt-0.5"> | ||
| <el-button | ||
| type="primary" | ||
| v-permission="'app_manage'" |
There was a problem hiding this comment.
The new hardcoded v-permission="'app_manage'" on start/stop/restart couples this shared component to App Store permissions, but AppStatus is reused in non-App-Store pages (for example website and database views). In those routes, users with module manage rights (e.g. website/database) but without app_manage will now have these controls disabled, which is a functional regression for service operations outside the app module.
Useful? React with 👍 / 👎.
| {{ $t('commons.button.download') }} | ||
| </el-button> | ||
| <el-button class="margin-button" @click="onClean" icon="Delete"> | ||
| <el-button v-permission="'container_manage'" class="margin-button" @click="onClean" icon="Delete"> |
There was a problem hiding this comment.
This component is used outside container pages (including website and database log screens), but the cleanup button now requires container_manage explicitly. That prevents users who have the relevant module manage permission for those pages, but not container permission, from cleaning logs in those contexts, introducing an unnecessary cross-module permission dependency in a shared widget.
Useful? React with 👍 / 👎.
2 participants
No description provided.