fix(mermaid): pass command as list to jobstart#46
Open
charlesg3 wants to merge 1 commit into
Open
Conversation
When command_parts is concatenated into a string, vim.fn.jobstart() runs it through the shell. This breaks arguments containing shell metacharacters — for example the '#' in hex color values like '#1A1B1C' passed via -b (background) is interpreted as a comment, silently dropping the color and all subsequent arguments. Spaces in file paths or cli_args values would also cause incorrect splitting. Passing command_parts as a list makes jobstart() execute the command directly without shell interpretation, per :help jobstart().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command_partslist directly tovim.fn.jobstart()instead of concatenating into a string withtable.concat()#in hex colors (treated as comments) and spaces in file paths:help jobstart()recommendation: passing a List runs the command directly without shellFixes #45
Also fixes #11 — hex background colors no longer need extra quoting