fix: SG-43605: OTIO export failing when OCIO is active, and support reversed-order stack blending#1291
Open
markreidvfx wants to merge 2 commits into
Conversation
When OCIO is active, CDL parameters live on the RVColor node rather than RVLinearize. Search both node types for an active CDL and export whichever is found, so CDL grades are not silently dropped in the exported OTIO timeline. Signed-off-by: Mark Reid <markreid@netflixanimation.com>
When an RVStack has supportReversedOrderBlending enabled, reverse the input ordering before writing the OTIO stack so the exported timeline matches the compositing order displayed in RV. Signed-off-by: Mark Reid <markreid@netflixanimation.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Fix OTIO export failing when OCIO is active, and support reversed-order stack blending.
When OCIO is enabled, the
RVLinearizenode is not present and the CDL parameters are instead located on anRVColornode. The export hook callsassociatedNode("RVLinearize"), which returns an empty string, and the subsequent call tocommands.getIntProperty("{}.CDL.active".format(linearize))then raises an exception.This fix loops over both
RVLinearizeandRVColornodes, checkingpropertyExistsbefore accessing CDL properties.Also reverses the input ordering when exporting an RVStack with
supportReversedOrderBlendingenabled, so the OTIO layer order matches RV.Describe the reason for the change.
OTIO export throws this exception when OCIO is active:
Describe what you have tested and on which operating system.
Tested on Rocky Linux 9.
"invalid property name .CDL.active"