fix: out-of-bounds access in audioFillBuffer#1302
Open
markreidvfx wants to merge 1 commit into
Open
Conversation
markreidvfx
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
Insert silence when sourceIndex is invalid instead of accessing the audio sources array out of bounds. Signed-off-by: Mark Reid <markreid@netflixanimation.com>
markreidvfx
force-pushed
the
nas_contrib_audio_oob_fix_v1
branch
from
79790d3 to
9f72f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A
Summarize your change.
Fix an out-of-bounds array access in
SequenceIPNode::audioFillBufferwhensourceIndexis invalid. Instead of accessing the audio sources array with a bad index, insert silence.Describe the reason for the change.
Identified by AddressSanitizer.
SequenceIPNode::audioFillBuffercan accessm_rangeInfosandinputs()out of bounds whensourceIndexis invalid. The fix validates the index before use and inserts silence for invalid sources instead of crashing.Describe what you have tested and on which operating system.
Tested on Rocky Linux 9.
Add a list of changes, and note any that might need special attention during the review.
SequenceIPNode.cpp: Add bounds check forsourceIndexinaudioFillBuffer; insert silence when the index is invalid.If possible, provide screenshots.
N/A