RAV-2958 - Initial Proxy Protocol processing#1
Merged
Merged
Conversation
cthirouin-swi
left a comment
cthirouin-swi
left a comment
Contributor
There was a problem hiding this comment.
Overall it's okay.
cthirouin-swi
approved these changes
Nov 7, 2025
cthirouin-swi
left a comment
cthirouin-swi
left a comment
Contributor
There was a problem hiding this comment.
I'ts fine, just couple of clarification.
sbernard31
reviewed
Nov 13, 2025
Co-authored-by: Simon Bernard <code@simonbernard.eu>
…e/v2/ProxyHeader.java Co-authored-by: Simon Bernard <code@simonbernard.eu>
…e/v2/ProxyHeader.java Co-authored-by: Simon Bernard <code@simonbernard.eu>
…e/v2/ProxyProtocolV2Decoder.java Co-authored-by: Simon Bernard <code@simonbernard.eu>
cthirouin-swi
requested changes
Nov 20, 2025
cthirouin-swi
left a comment
cthirouin-swi
left a comment
Contributor
There was a problem hiding this comment.
Just couple of minor stuff.
Co-authored-by: cthirouin <113358856+cthirouin-swi@users.noreply.github.com>
sbernard31
reviewed
Nov 21, 2025
sbernard31
approved these changes
Nov 24, 2025
Contributor
|
Last modification about usage of record could maybe be a not so good idea depending what we decide for : #7 But that sounds not a "prevent to merge" issue 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of ProxyProtocol protocol decoding.