Skip to content

[PWGLF] Table producer for photonDe correlation study#15509

Merged
maciacco merged 12 commits intoAliceO2Group:masterfrom
arvindkhuntia:master
Apr 27, 2026
Merged

[PWGLF] Table producer for photonDe correlation study#15509
maciacco merged 12 commits intoAliceO2Group:masterfrom
arvindkhuntia:master

Conversation

@arvindkhuntia
Copy link
Copy Markdown
Contributor

@arvindkhuntia arvindkhuntia commented Mar 24, 2026

No description provided.

@alibuild alibuild mentioned this pull request Mar 24, 2026
Merged
@alibuild alibuild mentioned this pull request Mar 24, 2026
Merged
@arvindkhuntia
Merge pull request #5 from alibuild/alibot-cleanup-15509
9dd013d 
Please consider the following formatting changes to AliceO2Group#15509
@maciacco maciacco marked this pull request as draft March 24, 2026 18:22
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 24, 2026

Error while checking build/O2Physics/o2 for 9dd013d at 2026-03-24 20:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15509-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:20:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 24, 2026

@arvindkhuntia How did you test your changes? They don't compile.

vkucera
vkucera reviewed Mar 24, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment thread PWGLF/TableProducer/Nuspex/CMakeLists.txt Outdated
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 6 warnings, 🔕 0 disabled

vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment thread PWGLF/DataModel/LFPhotonDeuteronTables.h Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx Outdated
vkucera
vkucera reviewed Apr 10, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/Nuspex/photonDeuteron.cxx
@vkucera vkucera marked this pull request as ready for review April 27, 2026 15:34
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 27, 2026

Error while checking build/O2Physics/o2 for 97c53b5 at 2026-04-27 17:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:197:38: error: unused parameter 'collision' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:107:51: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@maciacco maciacco merged commit 9ca168b into AliceO2Group:master Apr 27, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@maciacco maciacco maciacco approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

+1 more reviewer

@arvindiiti1992 arvindiiti1992 arvindiiti1992 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arvindkhuntia @alibuild @vkucera @maciacco @arvindiiti1992 @Arvindiiti