Skip to content

[PWGLF] refactor nucleiqc logic, fixed previous errors#15980

Open
GiorgioAlbertoLucia wants to merge 4 commits intoAliceO2Group:masterfrom
GiorgioAlbertoLucia:nucleiqc_new
Open

[PWGLF] refactor nucleiqc logic, fixed previous errors#15980
GiorgioAlbertoLucia wants to merge 4 commits intoAliceO2Group:masterfrom
GiorgioAlbertoLucia:nucleiqc_new

Conversation

@GiorgioAlbertoLucia
Copy link
Copy Markdown
Contributor

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented Apr 27, 2026

No description provided.

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as draft April 27, 2026 14:21
@github-actions github-actions Bot added the pwglf label Apr 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026 •
edited
Loading

O2 linter results: ❌ 5 errors, ⚠️ 41 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review April 27, 2026 14:37
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 27, 2026

Error while checking build/O2Physics/o2 for ab9de14 at 2026-04-27 16:54:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:384:50: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:152:10: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:250:44: error: 'PDG_t' has not been declared
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:322:84: error: 'kIsTriggerTVX' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:332:89: error: 'kNoTimeFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:337:93: error: 'kNoITSROFrameBorder' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:342:98: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kNoSameBunchPileup'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:347:98: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodZvtxFT0vsPV'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:352:99: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'; did you mean 'nuclei::kIsGoodITSLayersAll'?
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft April 27, 2026 15:19
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 27, 2026

@GiorgioAlbertoLucia Your PR does not compile on any system. How did you test it?

vkucera
vkucera requested changes Apr 27, 2026
View reviewed changes
Comment thread PWGLF/TableProducer/QC/nucleiQC.cxx
@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review April 27, 2026 15:40
@GiorgioAlbertoLucia
Copy link
Copy Markdown
Contributor Author

GiorgioAlbertoLucia commented Apr 27, 2026 •
edited
Loading

@GiorgioAlbertoLucia Your PR does not compile on any system. How did you test it?

Ciao @vkucera, it was building locally (ubuntu 24.04). It looked like the issues were some includes, I probably messed up something in the merge procedure, in fact your changes to the includes were not present in my PR.

I reverted to your include version and it still builds locally. Let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiorgioAlbertoLucia @alibuild @vkucera