[PWGCF] adding new task for multiparticle cumulants#15997
Draft
pykuan wants to merge 5 commits intoAliceO2Group:masterfrom
Draft
[PWGCF] adding new task for multiparticle cumulants#15997pykuan wants to merge 5 commits intoAliceO2Group:masterfrom
pykuan wants to merge 5 commits intoAliceO2Group:masterfrom
Conversation
pykuan
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
|
O2 linter results: ❌ 2 errors, |
github-actions
Bot
changed the title
vkucera
reviewed
Apr 28, 2026
vkucera
reviewed
Apr 28, 2026
victor-gonzalez
previously approved these changes
Apr 28, 2026
vkucera
requested changes
Apr 28, 2026
Comment on lines
+21
to
+24
| #include "Framework/AnalysisDataModel.h" | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/DataTypes.h" | ||
| #include "Framework/runDataProcessing.h" |
Collaborator
There was a problem hiding this comment.
This is still a wrong format.
Author
There was a problem hiding this comment.
May I ask what's wrong with the format?
Collaborator
There was a problem hiding this comment.
You need angle brackets for external headers.
Collaborator
There was a problem hiding this comment.
wenyaCern
previously approved these changes
Apr 29, 2026
Collaborator
|
Error while checking build/O2Physics/o2 for c1a4fb7 at 2026-04-29 08:51: Full log here. |
vkucera
reviewed
Apr 29, 2026
vkucera
reviewed
Apr 29, 2026
| qa.fQAHistogramsList->Add(qa.fQAHistograms[eQACent][0]); | ||
|
|
||
| wt.fWeightHistograms = getHistogramsWithWeights(tc.fFileWithWeights.c_str(), tc.fRunNumber.c_str()); | ||
| for (THIF* const& hist : wt.fWeightHistograms) { |
Collaborator
There was a problem hiding this comment.
- Here
const&doesn't make sense because you have pointers. Silence the O2 linter error. - You should not use explicit casting here. Either it is redundant or it is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.