Add Klarna Adapter#59
Conversation
Einswilli
left a comment
Einswilli
left a comment
There was a problem hiding this comment.
Thanks for contributoins!
|
|
||
| def validate_credentials(self) -> bool: | ||
| """Validate Klarna API credentials.""" | ||
| return bool(self.config.api_key and getattr(self.config, "api_username", None)) |
There was a problem hiding this comment.
i think api_username must be in the extra attr.
self.config here is an instance of ProviderConfig so it'd be better to have api_username and other aggregator specific config attrs in extra...
| """Validate Klarna webhook signature (if provided).""" | ||
| # Klarna allows optional signature validation via HMAC | ||
| signature = headers.get("klarna-signature") | ||
| secret = getattr(self.config, "webhook_secret", None) |
There was a problem hiding this comment.
Put webhook_secret in self.contiig.extra.
| "locale": "en-SE", | ||
| "order_amount": int(transaction.amount * 100), | ||
| "order_tax_amount": 0, | ||
| "order_lines": [ |
There was a problem hiding this comment.
Plase can you explain this section to me??? :-)
| } | ||
| ], | ||
| "merchant_urls": { | ||
| "confirmation": transaction.callback_url or "https://example.com/confirm", |
There was a problem hiding this comment.
use transaction.callback_url or self.config.callback_url.
| transaction_id=data.get("session_id"), | ||
| reference=transaction.reference, | ||
| provider=self.provider_name(), | ||
| status=TransactionStatus.PENDING.value, |
There was a problem hiding this comment.
No need unnecessary .value here.
| raw_response=data, | ||
| ) | ||
|
|
||
| async def cancel_transaction(self, transaction_id: str) -> None: |
There was a problem hiding this comment.
cancel_transaction must return a boolean.
| @pytest.fixture | ||
| def klarna_config(): | ||
| return { | ||
| "api_username": "test_user", |
| "api_username": "test_user", | ||
| "api_key": "test_key", | ||
| "environment": "sandbox", | ||
| "webhook_secret": "secret123", |
There was a problem hiding this comment.
I think you'll need to refractor tests based on the adapter changes...
|
I have done the changes, please check once |
|
Hey @Einswilli Can you please accept the pr, if the changes are correct? |
|
Hi @Sakshi146-eng can you please provide a screenshot of the tests??? |
|
Hi @Einswilli, Sorry for the long delay in addressing the requested changes. I've now completed all the updates and pushed them to this PR. Whenever you have time, I'd appreciate it if you could take another look. Thank you for your patience and for the review feedback. If everything looks good, I'd be grateful if you could consider merging the PR. Please find screenshot of test cases |
|
Hi @Sakshi146-eng! |
2 participants
Klarna Payment Adapter Integration
This PR introduces a new payment adapter for Klarna, enabling global “Pay Later” and “Pay Now” transactions via the EasySwitch SDK.
Addresses issue #58
✨ What's New
New Adapter:
KlarnaIntegratorfollowing the EasySwitchBaseAdapterinterfaceGlobal Support: Integration with Klarna’s REST API covering EU, US, and APAC regions
Flexible Payment Options: Supports deferred, installment, and direct payment methods
HMAC Webhook Security: Validates all incoming webhook signatures securely
Comprehensive Unit Tests & Documentation: Ensures full coverage and integration clarity
🌍 Supported Regions & Currencies
🔒 Webhook Security
Uses HMAC-SHA256 with the configured
webhook_secretValidates signature through
validate_webhook()Parses payload and normalizes status via
parse_webhook()Raises
PaymentErrorfor invalid or tampered webhooks🏗️ Architecture
Inherits from
BaseAdapterImplements all core abstract methods:
send_payment()check_status()refund()cancel_transaction()get_transaction_detail()Registered via
@AdaptersRegistry.register("klarna")Returns unified response types (
TransactionResult,WebhookEvent)Consistent exception handling through
PaymentError🧪 Tests
Unit Tests:
tests/test_klarna.pyCoverage includes:
Credential validation
Header generation (Base64 Auth)
Webhook parsing and signature validation
Transaction formatting and sending
Error handling for failed requests
Run with:
🚫 Unsupported / Not Implemented
❌ Partial refund operations (currently under evaluation)
❌ Currency conversion between unsupported Klarna markets