fix: rename shadowed local variables classpath and sourcepath#11
Open
sonarqube-agent[bot] wants to merge 1 commit into
Open
fix: rename shadowed local variables classpath and sourcepath#11sonarqube-agent[bot] wants to merge 1 commit into
sonarqube-agent[bot] wants to merge 1 commit into
Conversation
Fixed issues: - AZZmtiWq2HDYqP_XyoAs for java:S1117 rule Generated by SonarQube Agent (task: 99199e4e-753d-400a-b87b-66b6947c5827)
SonarQube reviewer guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes a SonarQube MAJOR issue where local variables were shadowing class fields with the same names. Renamed 'classpath' and 'sourcepath' to 'effectiveClasspath' and 'effectiveSourcepath' to eliminate the variable shadowing and improve code clarity.
View Project in SonarCloud
Fixed Issues
java:S1117 - Rename "classpath" which hides the field declared at line 58. • MAJOR • View issue
Location:
core/src/main/java/com/webcohesion/enunciate/Enunciate.java:528Why is this an issue?
Shadowing occurs when a local variable has the same name as a variable or a field in an outer scope.
What changed
Directly fixes the variable shadowing issue by renaming the local variables 'classpath' and 'sourcepath' to 'effectiveClasspath' and 'effectiveSourcepath', so they no longer shadow the class fields 'classpath' (declared at line 58) and 'sourcepath'. This eliminates the CODE_SMELL where a local variable hides a field of the same name.
SonarQube Remediation Agent uses AI. Check for mistakes.