fix: handle boolean return value from File.delete() in Enunciate

[sonarqube-agent]

Addressed SonarQube issue S899 by properly checking the boolean return value of tempDir.delete(). The fix wraps the delete call in a conditional check and logs a warning when deletion fails, ensuring file operations are properly validated instead of ignoring potential failures.

View Project in SonarCloud

---

Fixed Issues

java:S899 - Do something with the "boolean" value returned by "delete". • MINOR • View issue

Location: core/src/main/java/com/webcohesion/enunciate/Enunciate.java:288

Why is this an issue?

When the return value of a function call contains the operation status code, this value should be tested to make sure the operation completed successfully.

What changed

This hunk fixes the bug where the boolean return value of tempDir.delete() was being ignored. The static analysis rule requires that the status code returned by java.io.File operations like delete() must be checked. The fix wraps the call in an if (!tempDir.delete()) check and logs a warning message when the deletion fails, ensuring the return value is properly handled.

--- a/core/src/main/java/com/webcohesion/enunciate/Enunciate.java
+++ b/core/src/main/java/com/webcohesion/enunciate/Enunciate.java
@@ -288,1 +288,3 @@ public class Enunciate implements Runnable {
-    tempDir.delete();
+    if (!tempDir.delete()) {
+      getLogger().warn("Failed to delete temp file %s", tempDir);
+    }

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqubecloud]

SonarQube reviewer guide

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud