fix: resolve 5 SonarQube code quality issues

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Refactored four traditional for loops to for-of loops across multiple files for improved readability and eliminated unnecessary index variables. Additionally replaced String.match() with RegExp.exec() for better performance. These changes address MINOR code smells and align with TypeScript best practices for cleaner, more maintainable code.

View Project in SonarCloud

---

Fixed Issues

typescript:S4138 - Expected a `for-of` loop instead of a `for` loop with this simple iteration. • MINOR • View issue

Location: routes/search.ts:50

Why is this an issue?

for...of statements are used to iterate over the values of an iterable object. Iterables are objects implementing the @@iterator method, which returns an object conforming to the iterator protocol. JavaScript provides many built-in iterables that can and should be used with this looping statement.

What changed

Replaces a traditional for loop with index variable (for (let i = 0; i < tableDefinitions.data.length; i++)) with a for...of loop (for (const tableDefinition of tableDefinitions.data)), eliminating the unnecessary counter variable and directly iterating over the iterable array. The element access tableDefinitions.data[i].sql is replaced with the cleaner tableDefinition.sql.

--- a/routes/search.ts
+++ b/routes/search.ts
@@ -50,3 +50,3 @@ module.exports = function searchProducts () {
-              for (let i = 0; i < tableDefinitions.data.length; i++) {
-                if (tableDefinitions.data[i].sql) {
-                  solved = solved && utils.containsOrEscaped(dataString, tableDefinitions.data[i].sql)
+              for (const tableDefinition of tableDefinitions.data) {
+                if (tableDefinition.sql) {
+                  solved = solved && utils.containsOrEscaped(dataString, tableDefinition.sql)

typescript:S6594 - Use the "RegExp.exec()" method instead. • MINOR • View issue

Location: lib/insecurity.ts:120

Why is this an issue?

String.match() behaves the same way as RegExp.exec() when the regular expression does not include the global flag g. While they work the same, RegExp.exec() can be slightly faster than String.match(). Therefore, it should be preferred for better performance.

What changed

This hunk replaces coupon.match(/(JAN|FEB|MAR|APR|...)/) with /(JAN|FEB|MAR|APR|...).exec(coupon), converting from String.match() to RegExp.exec(). Since the regex does not use the global flag g, these two calls are semantically equivalent, but RegExp.exec() is preferred for slightly better performance. This directly addresses the code smell about using String.match() instead of RegExp.exec() in lib/insecurity.ts at line 120.

--- a/lib/insecurity.ts
+++ b/lib/insecurity.ts
@@ -120,1 +120,1 @@ function hasValidFormat (coupon: string) {
-  return coupon.match(/(JAN|FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV|DEC)[0-9]{2}-[0-9]{2}/)
+  return /(JAN|FEB|MAR|APR|MAY|JUN|JUL|AUG|SEP|OCT|NOV|DEC)[0-9]{2}-[0-9]{2}/.exec(coupon)

typescript:S4138 - Expected a `for-of` loop instead of a `for` loop with this simple iteration. • MINOR • View issue

Location: routes/search.ts:31

Why is this an issue?

for...of statements are used to iterate over the values of an iterable object. Iterables are objects implementing the @@iterator method, which returns an object conforming to the iterator protocol. JavaScript provides many built-in iterables that can and should be used with this looping statement.

What changed

Replaces a traditional for loop with index variable (for (let i = 0; i < users.data.length; i++)) with a for...of loop (for (const user of users.data)), eliminating the unnecessary counter variable and directly iterating over the iterable array. The element access users.data[i].email and users.data[i].password are replaced with the cleaner user.email and user.password.

--- a/routes/search.ts
+++ b/routes/search.ts
@@ -31,2 +31,2 @@ module.exports = function searchProducts () {
-              for (let i = 0; i < users.data.length; i++) {
-                solved = solved && utils.containsOrEscaped(dataString, users.data[i].email) && utils.contains(dataString, users.data[i].password)
+              for (const user of users.data) {
+                solved = solved && utils.containsOrEscaped(dataString, user.email) && utils.contains(dataString, user.password)

typescript:S4138 - Expected a `for-of` loop instead of a `for` loop with this simple iteration. • MINOR • View issue

Location: routes/search.ts:64

Why is this an issue?

for...of statements are used to iterate over the values of an iterable object. Iterables are objects implementing the @@iterator method, which returns an object conforming to the iterator protocol. JavaScript provides many built-in iterables that can and should be used with this looping statement.

What changed

Replaces a traditional for loop with index variable (for (let i = 0; i < products.length; i++)) with a for...of loop (for (const product of products)), eliminating the unnecessary counter variable and directly iterating over the iterable array. The element access products[i].name and products[i].description are replaced with the cleaner product.name and product.description.

--- a/routes/search.ts
+++ b/routes/search.ts
@@ -64,3 +64,3 @@ module.exports = function searchProducts () {
-        for (let i = 0; i < products.length; i++) {
-          products[i].name = req.__(products[i].name)
-          products[i].description = req.__(products[i].description)
+        for (const product of products) {
+          product.name = req.__(product.name)
+          product.description = req.__(product.description)

typescript:S4138 - Expected a `for-of` loop instead of a `for` loop with this simple iteration. • MINOR • View issue

Location: frontend/src/app/photo-wall/mime-type.validator.ts:23

Why is this an issue?

for...of statements are used to iterate over the values of an iterable object. Iterables are objects implementing the @@iterator method, which returns an object conforming to the iterator protocol. JavaScript provides many built-in iterables that can and should be used with this looping statement.

What changed

This hunk replaces a traditional for loop (for (let i = 0; i < arr.length; i++)) with a for...of loop (for (const byte of arr)), which is the recommended way to iterate over iterable objects like arrays. The original code used an index-based for loop to iterate through arr and accessed elements via arr[i], which is flagged as a code smell because arr is an iterable and should be iterated using for...of for better readability and simplicity. The fix eliminates the counter variable and directly accesses each element as byte.

--- a/frontend/src/app/photo-wall/mime-type.validator.ts
+++ b/frontend/src/app/photo-wall/mime-type.validator.ts
@@ -23,2 +23,2 @@ export const mimeType = (
-        for (let i = 0; i < arr.length; i++) {
-          header += arr[i].toString(16)
+        for (const byte of arr) {
+          header += byte.toString(16)

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.