Skip to content

Harden product review routes against NoSQL injection #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Harden product review routes against NoSQL injection #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions routes/createProductReviews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,22 @@ import { challenges } from '../data/datacache'
const security = require('../lib/insecurity')

module.exports = function productReviews () {
return (req: Request, res: Response) => {
return (req: Request, res: Response, next: (err?: Error) => void) => {
const user = security.authenticatedUsers.from(req)
challengeUtils.solveIf(challenges.forgedReviewChallenge, () => { return user && user.data.email !== req.body.author })
const product = req.params?.id
const author = req.body?.author
const message = req.body?.message

if (typeof product !== 'string' || typeof author !== 'string' || typeof message !== 'string') {
next(new Error('Blocked illegal activity by ' + req.socket.remoteAddress))
return
}

challengeUtils.solveIf(challenges.forgedReviewChallenge, () => { return user && user.data.email !== author && user.data.email !== product })
reviewsCollection.insert({
product: req.params.id,
message: req.body.message,
author: req.body.author,
product,
message,
author,
likesCount: 0,
likedBy: []
}).then(() => {
Expand Down
7 changes: 6 additions & 1 deletion routes/updateProductReviews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@ const security = require('../lib/insecurity')
module.exports = function productReviews () {
return (req: Request, res: Response, next: NextFunction) => {
const user = security.authenticatedUsers.from(req) // vuln-code-snippet vuln-line forgedReviewChallenge
const id = req.body?.id?.toString()
if (typeof id !== 'string') {
next(new Error('Blocked illegal activity by ' + req.socket.remoteAddress))
return
}
db.reviewsCollection.update( // vuln-code-snippet neutral-line forgedReviewChallenge
{ _id: req.body.id }, // vuln-code-snippet vuln-line noSqlReviewsChallenge forgedReviewChallenge
{ _id: id }, // vuln-code-snippet vuln-line noSqlReviewsChallenge forgedReviewChallenge
{ $set: { message: req.body.message } },
{ multi: true } // vuln-code-snippet vuln-line noSqlReviewsChallenge
).then(
Expand Down