fix: resolve 5 SonarQube code quality issues

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Replaced String.match() calls with RegExp.exec() for better performance on non-global regular expressions, and consolidated duplicate imports from the lightspeed interfaces module. These changes address SonarQube's recommendations for improved performance and code maintainability.

View Project in SonarCloud

---

Fixed Issues

typescript:S6594 - Use the "RegExp.exec()" method instead. • MINOR • View issue

Location: src/features/lightspeed/errors.ts:291

Why is this an issue?

String.match() behaves the same way as RegExp.exec() when the regular expression does not include the global flag g. While they work the same, RegExp.exec() can be slightly faster than String.match(). Therefore, it should be preferred for better performance.

What changed

This hunk replaces body.toLowerCase().match("cloudfront") with /cloudfront/.exec(body.toLowerCase()), converting from String.match() to RegExp.exec() for better performance. The static analysis rule flags String.match() calls that can be replaced with semantically equivalent RegExp.exec() calls, since RegExp.exec() can be slightly faster when the regex does not include the global flag.

--- a/src/features/lightspeed/errors.ts
+++ b/src/features/lightspeed/errors.ts
@@ -291,1 +291,1 @@ ERRORS.addError(
-          (body.toLowerCase().match("cloudfront")?.length || 0) > 0;
+          (/cloudfront/.exec(body.toLowerCase())?.length || 0) > 0;

typescript:S6594 - Use the "RegExp.exec()" method instead. • MINOR • View issue

Location: src/features/lightspeed/errors.ts:293

Why is this an issue?

String.match() behaves the same way as RegExp.exec() when the regular expression does not include the global flag g. While they work the same, RegExp.exec() can be slightly faster than String.match(). Therefore, it should be preferred for better performance.

What changed

This hunk replaces body.toLowerCase().match("blocked") with /blocked/.exec(body.toLowerCase()), converting from String.match() to RegExp.exec() for better performance. The static analysis rule flags String.match() calls that can be replaced with semantically equivalent RegExp.exec() calls, since RegExp.exec() can be slightly faster when the regex does not include the global flag.

--- a/src/features/lightspeed/errors.ts
+++ b/src/features/lightspeed/errors.ts
@@ -293,1 +293,1 @@ ERRORS.addError(
-          (body.toLowerCase().match("blocked")?.length || 0) > 0;
+          (/blocked/.exec(body.toLowerCase())?.length || 0) > 0;

typescript:S6594 - Use the "RegExp.exec()" method instead. • MINOR • View issue

Location: src/features/lightspeed/utils/data.ts:433

Why is this an issue?

String.match() behaves the same way as RegExp.exec() when the regular expression does not include the global flag g. While they work the same, RegExp.exec() can be slightly faster than String.match(). Therefore, it should be preferred for better performance.

What changed

Replaces String.match() with RegExp.exec() for the regex /^\s*-\s*/ on line 466. The static analysis rule flags String.match() calls that can be replaced with the semantically equivalent but slightly faster RegExp.exec(). The original code documentLines[indentIndex].match(/^\s*-\s*/) is rewritten to /^\s*-\s*/.exec(documentLines[indentIndex]), which resolves the warning about using RegExp.exec() instead of String.match() for non-global regular expressions for better performance.

--- a/src/features/lightspeed/utils/data.ts
+++ b/src/features/lightspeed/utils/data.ts
@@ -466,1 +466,1 @@ function shouldTriggerMultiTaskSuggestionForPlaybook(
-          const matched = documentLines[indentIndex].match(/^\s*-\s*/);
+          const matched = /^\s*-\s*/.exec(documentLines[indentIndex]);

typescript:S6594 - Use the "RegExp.exec()" method instead. • MINOR • View issue

Location: src/features/lightspeed/utils/data.ts:466

Why is this an issue?

String.match() behaves the same way as RegExp.exec() when the regular expression does not include the global flag g. While they work the same, RegExp.exec() can be slightly faster than String.match(). Therefore, it should be preferred for better performance.

What changed

Replaces String.match() with RegExp.exec() for the regex /^\s*-\s*/ on line 466. The static analysis rule flags String.match() calls that can be replaced with the semantically equivalent but slightly faster RegExp.exec(). The original code documentLines[indentIndex].match(/^\s*-\s*/) is rewritten to /^\s*-\s*/.exec(documentLines[indentIndex]), which resolves the warning about using RegExp.exec() instead of String.match() for non-global regular expressions for better performance.

--- a/src/features/lightspeed/utils/data.ts
+++ b/src/features/lightspeed/utils/data.ts
@@ -466,1 +466,1 @@ function shouldTriggerMultiTaskSuggestionForPlaybook(
-          const matched = documentLines[indentIndex].match(/^\s*-\s*/);
+          const matched = /^\s*-\s*/.exec(documentLines[indentIndex]);

typescript:S3863 - '../../interfaces/lightspeed' imported multiple times. • MINOR • View issue

Location: src/features/lightspeed/inlineSuggestions.ts:15

Why is this an issue?

Having the same module imported multiple times can affect code readability and maintainability. It makes hard to identify which modules are being used.

What changed

This hunk moves the IAnsibleFileType import into the existing import block from '../../interfaces/lightspeed', consolidating it with the other imports from the same module. This helps fix the duplicate import issue where '../../interfaces/lightspeed' was imported multiple times in separate import statements.

--- a/src/features/lightspeed/inlineSuggestions.ts
+++ b/src/features/lightspeed/inlineSuggestions.ts
@@ -14,0 +15,1 @@ import {
+  IAnsibleFileType,

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqubecloud]

SonarQube reviewer guide

Quality Gate passed

Issues
1 New issue
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud