Skip to content

feat(wallpaper): add folder-based wallpaper selection and shuffle - #2990

Open
greenbugx wants to merge 2 commits into
AvengeMedia:masterfrom
greenbugx:feat/wallpaper-folder
Open

feat(wallpaper): add folder-based wallpaper selection and shuffle#2990
greenbugx wants to merge 2 commits into
AvengeMedia:masterfrom
greenbugx:feat/wallpaper-folder

Conversation

@greenbugx

Copy link
Copy Markdown

Description

Adds a dedicated folder picker in the Settings wallpaper tab, allowing users to explicitly select an entire directory for automatic cycling without needing to manually select a dummy file.

Additionally, introduces a new Shuffle toggle to the Automatic Cycling configuration. When enabled, the background service seamlessly pipes the dynamically queried wallpaper list to shuf instead of sort, ensuring a truly random wallpaper is picked on every cycle while immediately adapting to any external file changes in the directory (e.g. from Nix or sync tools).

Note: Depends on the dank-qml-common FileBrowser folderMode fix submitted in this PR to resolve folder highlighting edge cases.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Closes #2833

Screenshots / video

image image
recording.mp4

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@greenbugx
greenbugx force-pushed the feat/wallpaper-folder branch from f8a6db0 to 83c600a Compare August 5, 2026 15:48

@bbedward bbedward left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the qml-common change, so you can bump the submodule ref in this PR

Comment thread quickshell/Modules/Settings/WallpaperTab.qml
@greenbugx
greenbugx force-pushed the feat/wallpaper-folder branch from a767f9a to f298161 Compare August 7, 2026 16:56
@greenbugx
greenbugx requested a review from bbedward August 7, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallpaper folders

2 participants