fix: config func - #9195
Open
Tim Wright (timmy-wright) wants to merge 1 commit into
Open
Conversation
Tim Wright (timmy-wright)
requested review from
Chou Hu (AbelHu),
Devinwong,
Sri Harsha (SriHarsha001),
Nishchay (awesomenix),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Peter Damianov (pdamianov-dev),
Patrick W. Healy (phealy),
r2k1,
Runzhen (runzhen),
sulixu,
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
August 13, 2026 05:40
Contributor
Windows Unit Test Results 3 files 12 suites 41s ⏱️ For more details on these failures, see this check. Results for commit bb0e673. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to harden Windows CSE configfunc.ps1 by adding stricter error handling around external command invocations and improving service install idempotency, with accompanying Pester test updates in the staging Windows CSE package.
Changes:
- Added
$LASTEXITCODEchecks (and some fail-fast behavior) aftersc.exe,reg.exe import, andicaclsoperations. - Refactored
New-CsiProxyService/New-HostsConfigServiceto remove an existing service before reinstalling and to use anInvoke-Nssmhelper (with new unit tests). - Reformatted/cleaned up portions of the Pester tests and added service-install coverage for
csi-proxyandhosts-config-agent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| staging/cse/windows/configfunc.ps1 | Adds command exit-code hardening; refactors service creation to rely on new helper(s). |
| staging/cse/windows/configfunc.tests.ps1 | Adds/updates Pester tests, including new coverage for service creation behaviors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
2
| . $PSScriptRoot\helpers.ps1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden config func
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #