test(e2e): run core GPU suite on PRs - #9254
Conversation
9f5645d to
5b4c896
Compare
There was a problem hiding this comment.
Pull request overview
Adds PR-aware GPU E2E selection while retaining full coverage for scheduled and non-PR runs.
Changes:
- Runs three core Ubuntu GPU tests by default on PRs.
- Adds full-suite opt-in through the PR template.
- Selects and exports the appropriate E2E test filters.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pipelines/templates/e2e-template.yaml |
Adds profile-selection step. |
.pipelines/scripts/select_gpu_e2e_profile.sh |
Implements profile selection. |
.pipelines/e2e-gpu.yaml |
Enables automatic GPU profile selection. |
.github/PULL_REQUEST_TEMPLATE.md |
Adds full-suite checkbox. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| readonly CORE_GPU_E2E_TESTS=( | ||
| Test_Ubuntu2404_GPUA10 | ||
| Test_Ubuntu2404_NvidiaDevicePluginRunning | ||
| Test_Ubuntu2404_NvidiaDevicePluginRunning_MIG | ||
| ) |
| else | ||
| log_warning "Unable to read PR body; running default core GPU E2E suite" | ||
| fi |
Windows Unit Test Results 3 files 13 suites 57s ⏱️ Results for commit 6e575c5. ♻️ This comment has been updated with latest results. |
5b4c896 to
6e575c5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (5)
.pipelines/scripts/select_gpu_e2e_profile.sh:27
- 🟡 Medium Risk — 🔧 Script Logic: This
[[ ... ]]condition triggers SC3010 in the repository’s required POSIX ShellCheck pass. Use parameter expansion with[ ... ]so the slash check retains its current behavior while passing CI.
repository_name="${BUILD_REPOSITORY_NAME:-Azure/AgentBaker}"
.pipelines/scripts/select_gpu_e2e_profile.sh:31
- 🟡 Medium Risk — 🔧 Script Logic: The repository’s POSIX ShellCheck pass reports SC3010 for this Bash conditional, which makes
make validate-shellfail. Use the portable test syntax.
repository_name="Azure/${repository_name}"
.pipelines/scripts/select_gpu_e2e_profile.sh:44
- 🟡 Medium Risk — 🔧 Script Logic: This Bash conditional is rejected with SC3010 by the POSIX ShellCheck stage in
.pipelines/scripts/verify_shell.sh. Use the portable test syntax so the new script passes the repository gate.
--location \
.pipelines/scripts/select_gpu_e2e_profile.sh:52
- 🟡 Medium Risk — 🔧 Script Logic: This line fails the required POSIX ShellCheck pass with SC3010; after converting to
[ ... ], POSIX also requires=rather than==. Use the portable comparison below.
.pipelines/scripts/select_gpu_e2e_profile.sh:64 - 🟡 Medium Risk — 🔧 Script Logic: This condition is another SC3010 failure under the repository’s POSIX ShellCheck pass. Use
[ ... ]with the POSIX equality operator somake validate-shellsucceeds.
profile=full
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.pipelines/scripts/select_gpu_e2e_profile.sh:61
- 🟡 Medium Risk — 🔧 Script Logic: The unauthenticated request has the same masked-failure behavior: when
curlfails or is rate-limited, empty input still gives plainjq -ra successful exit status. Consequently, the PR checkbox can be ignored with no warning. Requirejqto fail when no result is produced soread_pr_bodyreturns failure.
jq -r '.body // ""'
.pipelines/scripts/select_gpu_e2e_profile.sh:49
- 🟡 Medium Risk — 🔧 Script Logic: A failed authenticated
curlis masked because the pipeline returnsjq's status;jqexits successfully when it receives no input. The checked full-suite opt-in then silently falls back to the core profile instead of reaching the warning path. Makejqrequire a produced result so API failures propagate.
This issue also appears on line 61 of the same file.
jq -r '.body // ""'
What this changes
Core tests:
Test_Ubuntu2404_GPUA10Test_Ubuntu2404_NvidiaDevicePluginRunningTest_Ubuntu2404_NvidiaDevicePluginRunning_MIGValidation
shellcheck .pipelines/scripts/select_gpu_e2e_profile.shgit diff --check