Fix encoding bug: replace Encoding.ASCII with Encoding.Latin1#2
Open
carlbennett wants to merge 1 commit intodevelopfrom
Open
Fix encoding bug: replace Encoding.ASCII with Encoding.Latin1#2carlbennett wants to merge 1 commit intodevelopfrom
carlbennett wants to merge 1 commit intodevelopfrom
Conversation
34c24b2 to
f30881d
Compare
Battle.net protocol specifies ISO 8859-1 (Latin1) for string fields. Using ASCII silently corrupts any byte above 0x7F to '?' before hashing or transmission, causing auth failures for users with extended characters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
f30881d to
58493c2
Compare
Member
Author
|
Verified: usernames with extended Latin1 characters exist in the wild. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encoding.ASCIIsilently corrupts bytes above 0x7F to?before hashing, causing auth failures for extended charactersTest plan
🤖 Generated with Claude Code