Skip to content

ci: add weekly cron job; add templates, contributing and codeowners #5

Merged
KyrylR merged 5 commits into
BlockstreamResearch:masterfrom
gerau:org/github
Jun 19, 2026
Merged

ci: add weekly cron job; add templates, contributing and codeowners #5
KyrylR merged 5 commits into
BlockstreamResearch:masterfrom
gerau:org/github

Conversation

@gerau

@gerau gerau commented May 27, 2026

Copy link
Copy Markdown
Collaborator

This adds weekly job to check if current version of simplicityhl crate is the same as a stable version on crates.io. Not sure if that would work correctly, because I don't know how to properly test it.

Also adds templates for issues, CONTRIBUTING.md and CODEOWNERS files

on:
workflow_run: # zizmor: ignore[dangerous-triggers]
workflows:
- Sync compiler

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is a sync compiler workflow?

Comment thread .github/workflows/cron-weekly-sync.yml Outdated
@@ -0,0 +1,35 @@
name: Weekly Dependency Check

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this named correctly?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow_run.workflows filter matches workflow names, so the issue-sync workflow will never trigger for this weekly check.

Comment on lines +12 to +13
permissions:
issues: write

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
permissions:
issues: write
permissions:
issues: write
actions: read

- name: Download Artifact
uses: actions/download-artifact@v4
with:
name: outdated-results

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: outdated-results
name: outdated-results
run-id: ${{ github.event.workflow_run.id }}
github-token: ${{ github.token }}

runs-on: ubuntu-24.04

steps:
- name: Download Artifact

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downloads outdated-results without run-id or github-token, actions/download-artifact@v4 defaults to the current workflow run, not the completed upstream workflow, so this job will probably not find the artifact

Comment thread .github/workflows/ci-failure-issues.yml Outdated
const parsedData = JSON.parse(rawData);
const dependencies = parsedData.dependencies;

const dep = dependencies[0];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the list is empty?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add check for the dependencies

@gerau

gerau commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

applied suggested changes

@gerau gerau requested a review from KyrylR May 28, 2026 08:49
KyrylR
KyrylR approved these changes Jun 19, 2026
@KyrylR KyrylR merged commit 07da16d into BlockstreamResearch:master Jun 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants