work harder at keeping Bloom on-screen at wakeup (BL-16355)

[JohnThomson]

This change is 

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/BloomExe/Shell.cs">

<violation number="1" location="src/BloomExe/Shell.cs:146">
P2: Don’t always unsubscribe on `OnHandleDestroyed`. Handle can be recreated. Then system-event hooks get removed and never come back. Guard this for real teardown only.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Don’t always unsubscribe on OnHandleDestroyed. Handle can be recreated. Then system-event hooks get removed and never come back. Guard this for real teardown only.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/BloomExe/Shell.cs, line 146:

<comment>Don’t always unsubscribe on `OnHandleDestroyed`. Handle can be recreated. Then system-event hooks get removed and never come back. Guard this for real teardown only.</comment>

<file context>
@@ -138,6 +141,12 @@ protected override void OnHandleCreated(EventArgs e)
 
+        protected override void OnHandleDestroyed(EventArgs e)
+        {
+            UnsubscribeFromSystemWindowEvents();
+            base.OnHandleDestroyed(e);
+        }
</file context>

Suggested change

	UnsubscribeFromSystemWindowEvents();
	if (!RecreatingHandle)
	UnsubscribeFromSystemWindowEvents();