Prevent gallery clicks from scrolling preview to top#3780
Open
apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
Open
Prevent gallery clicks from scrolling preview to top#3780apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3021.\n\n## Summary\n- Add a click handler for rendered gallery blocks.\n- Preserve carousel click handling while preventing default hash-link navigation.\n- Stop gallery arrow/thumbnail clicks from moving the preview document back to the top.\n\n## Validation\n- Ran:
git diff --check.\n- Not run: project ESLint/tests because dependencies are not installed in this checkout.