Avoid Ctrl-R reload when Vim keymap is enabled#3781
Open
apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
Open
Avoid Ctrl-R reload when Vim keymap is enabled#3781apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
apples-kksk wants to merge 1 commit intoBoostIO:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2825.\n\n## Summary\n- Keep the normal reload shortcut as
CommandOrControl+Rfor non-Vim users.\n- When the editor keymap is Vim, switch the reload accelerator toCommandOrControl+Shift+R.\n- Rebuild the app menu on config renewal so changing the keymap updates the accelerator without affecting other users.\n\nThis follows the review feedback from the older closed PR #3645: the shortcut change is limited to Vim keybind users only.\n\n## Validation\n- Ran:node -c lib/main-menu.js.\n- Ran:git diff --check.