feat(atemschutz): spoken Druckabfrage + Rückzugsalarm cues - #149
Merged
Conversation
DeepDiver1975
force-pushed
the
feat/scba-druckabfrage-audio-cue
branch
from
August 29, 2026 21:31
032034a to
2bfea6a
Compare
DeepDiver1975
changed the title
DeepDiver1975
marked this pull request as ready for review
August 29, 2026 22:25
DeepDiver1975
force-pushed
the
feat/scba-druckabfrage-audio-cue
branch
from
August 30, 2026 20:31
a127e4d to
d6cfd27
Compare
… due The pressure-control reminder was visual-only (an amber banner) -- easy to miss when the operator isn't looking at the screen, which is exactly when it matters most. Adds AlarmSound.ScbaControlDue, reusing the existing alarm.wav tone (same choice/rationale already recorded for AlarmSound.TaskDue: a spoken sentence would be more noise than signal for an event recurring every few minutes per Trupp). Plays once per due-crossing per Trupp, silencing again the instant a pressure reading is recorded until the next Abfrage-Intervall elapses -- mirroring TasksViewModel's one-shot due-sound pattern, including its choice to gate only on IsReadOnly (not IsRemote): sound is local feedback for whoever is looking at a device, not a journal write that must only happen once. Marked as a draft PR: not yet ready. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UwN31QccH98YV9eEc2bue2 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
…ckabfrage cue (#81) Aligns this branch with issue #81: renames AlarmSound.ScbaControlDue to PressureCheckDue and gives it its own spoken clip (voice-druckabfrage.wav) instead of reusing the generic alarm.wav tone, and replaces the looping Rückzugsalarm siren with a spoken "Rückzugsalarm" cue (voice-rueckzugsalarm.wav) repeated every 15s while unacknowledged -- mirroring ReminderViewModel's existing repeat-until-acknowledged cadence for the ILS reminder, just at 15s given the life-safety stakes instead of 60s. IAlarmService.Start()/Stop() are removed entirely now that nothing loops a siren anymore -- they were only ever called from ScbaViewModel (4 call sites), confirmed by grep across the whole app. Both voice clips were AI-generated and supplied as MP3; converted to mono 16-bit PCM WAV @ 22050Hz via ffmpeg to match every other bundled voice asset and SystemAlarmService's existing WAV-only playback paths (Windows winmm PlaySound and Linux aplay don't decode MP3). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UwN31QccH98YV9eEc2bue2 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
SystemAlarmService.Play() was fire-and-forget on all platforms, so two cues becoming due in the same tick (e.g. a Trupp's RetreatAlarm and another Trupp's PressureCheckDue) played concurrently and talked over each other. Playback now goes through a SerialAudioQueue that runs cues one at a time on a dedicated background thread, with a watchdog timeout so a hung OS player can't permanently block later alarms. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Start()/Stop() referenced _sounding, _wav, SndAsync and SndLoop, none of which exist anymore — the branch rebase onto main kept these method bodies from main's old looping-siren SystemAlarmService while also keeping this branch's removal of their backing fields (main's siren was already fully replaced by spoken Play() cues here). Neither method is called anywhere (IAlarmService doesn't declare them), so this was dead code left by an incomplete conflict resolution, breaking the build (CS0103) on both CI platforms. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
feat/scba-druckabfrage-audio-cue
branch
from
August 30, 2026 20:55
d1a6ed5 to
1d3ce59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81. Aligns this branch with the issue (which superseded the original, narrower scope of this PR):
AlarmSound.ScbaControlDue→ renamed toAlarmSound.PressureCheckDue, now with its own spoken clipvoice-druckabfrage.wavinstead of the reused genericalarm.wavtone. Still plays once per due-crossing per Trupp, silenced by a recorded pressure reading until the next Abfrage-Intervall.alarm.wavsiren is gone. A spoken "Rückzugsalarm" cue (voice-rueckzugsalarm.wav) now repeats every 15s while unacknowledged, mirroringReminderViewModel's existing repeat-until-acknowledged cadence for the ILS reminder (same pattern, 15s instead of 60s given the life-safety stakes).IAlarmService.Start()/Stop()removed entirely — confirmed via a full-repo grep thatScbaViewModelwas their only caller (4 call sites), so nothing else needed touching once the siren was gone.ffmpegto match every other bundled voice asset andSystemAlarmService's WAV-only playback paths (winmm on Windows andaplayon Linux don't decode MP3).Test plan
dotnet test tests/LageBuch.AppLogic.Tests— full suite green (299 tests), including a rework of every Rückzugsalarm test offIsSounding/Start/Stoponto assertingFakeAlarmService.Played, plus new tests for the 15s repeat cadence and the immediate-reannounce-after-ack behavior for a newly-alarming Trupp.aplay(the same code pathSystemAlarmServiceuses on Linux) — correct format, no errors.FakeAlarmService.Playedassertions.🤖 Generated with Claude Code
https://claude.ai/code/session_01UwN31QccH98YV9eEc2bue2