fix: make culture-sensitive formatting explicit (CA1305) - #156
Merged
Conversation
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/analyzer-culture-invariant
branch
from
August 30, 2026 20:12
77ec7d5 to
50e1f5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the analyzer-hardening effort (see #153 for rule scoping).
Changes: All 18 CA1305 findings — every locale-variant conversion now names its provider.
IncidentRepository(Convert.ToInt32/int.Parseon SQLite+$ 'apartment_labels'/floor_descriptionsJSON keys),Migrations.GetVersion,SnapshotMapperwire format (int dict keys both directions),IncidentHostController4-digit PIN (D4)ForcesSectionStärke counters — keeps generated PDF bytes deterministic across host localesHomeViewModel.NewIncidentAsync,ScbaTruppRow.StartTimeDisplayHH:mm— numeric-only formats, no visible changeConvert.ToInt32(enum)ordering → plain(int)castVerification: full harness build (
--no-incremental,AnalysisMode=All) shows CA1305 = 0, 0 errors, all other rule counts equal to main baseline; all 801 tests pass.