refactor(sync): pass Uri to HttpClient instead of path strings (CA2234) - #163
Merged
Conversation
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CA2234 flags passing a string to HttpClient.GetAsync/GetStringAsync/PostAsync when the relative string is only ever turned into a Uri — the string overloads accept and strip query strings, conflate base-address handling, and re-parse on every call.
All 20 sites (40 warnings) fixed by passing
new Uri(path, UriKind.RelativeOrAbsolute)— byte-for-byte what HttpClient's string overload does internally, so behavior is unchanged and the analyzer is satisfied:Verification: CA2234 at 0 under AnalysisMode=All, zero errors, no change to any other rule; full suite 801 passed / 1 skipped.