Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | implement-and-rewrite-tests#1407
Open
Motorcycle-lab wants to merge 7 commits into
Open
Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | implement-and-rewrite-tests#1407Motorcycle-lab wants to merge 7 commits into
Motorcycle-lab wants to merge 7 commits into
Conversation
Motorcycle-lab
added
📅 Sprint 3
LonMcGregor
reviewed
Jul 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Why did you make a commit with simply a comment of "for committing". Do you know what you need to do in this task?
LonMcGregor
added
Reviewed
Motorcycle-lab
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
force-pushed
the
implement-and-rewrite-tests
branch
from
90451be to
212966d
Compare
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Motorcycle-lab
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Author
|
Motorcycle-lab
added
the
Needs Review
LonMcGregor
reviewed
Jul 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, you may want to expand your test cases some more, though.
Also, remember to do the tasks in the "rewrite tests with jest" directory
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
|
|
||
| return numerator< denominator ; |
There was a problem hiding this comment.
Think about all the possible cases of fractions you could have. For example, does this cover -2/3?
|
|
||
| const value = Number(rank); | ||
|
|
||
| if( value>=2 && value <= 10 ){ |
There was a problem hiding this comment.
Did you remember to use the formatter in your IDE before committing?
LonMcGregor
added
Reviewed
Motorcycle-lab
added
Needs Review
LonMcGregor
reviewed
Jul 7, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this task is now complte
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
my exercises in implement-and-rewrite tests
Questions
What websites or apps do you recommend me build to learn the foundation of Javascript ?