West Midlands | ITP-26-May | Alina Sofragiu | Sprint 3 | Practice TDD#1420
West Midlands | ITP-26-May | Alina Sofragiu | Sprint 3 | Practice TDD#1420sofragiualina wants to merge 2 commits into
Conversation
sofragiualina
added
📅 Sprint 3
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but I think you could expand your test cases a bit further
| @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => { | |||
| // And a character `char` that does not exist within `str`. | |||
| // When the function is called with these inputs, | |||
| // Then it should return 0, indicating that no occurrences of `char` were found. | |||
There was a problem hiding this comment.
Good test case for 0. Are there any other test cases you think you should add?
There was a problem hiding this comment.
yes, I added more test cases for a single occurrence, an empty string, and case sensitivity
There was a problem hiding this comment.
These are good to test your edge cases. Do any of these test the normal operation of the repeat function?
There was a problem hiding this comment.
yes, first test checks that the string is repeated multiple times count=3 and the second one checks the normal case count=1
LonMcGregor
added
Reviewed
sofragiualina
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work with these new test cases. This task is complete now
LonMcGregor
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Completed Test-Driven Development practice