London | 26-ITP_May | Vito Moratti | Sprint 2 | Coursework/sprint 2 by vmoratti · Pull Request #1429 · CodeYourFuture/Module-Structuring-and-Testing-Data

vmoratti · 2026-06-30T13:02:18Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the exercises in the course work.

LonMcGregor

Good start, and well done on attempting the stretch task. I've left a couple of comments for further improvements

LonMcGregor · 2026-07-06T10:26:03Z

-    // return the BMI of someone based off their weight and height
-}
+    let bmi = weight / (height **2 )// weight divided by height squared.
+    return  `Your Body Mass Index is ${bmi.toFixed(1)} units`// toFixed(1) insures that result is displayed 


Have a look at the comment above. It says the function should "return their Body Mass Index to 1 decimal place". Your function works, but does it meet this specific criteria?

Sorry, but i don't understand what am I missing. The function returns correct BMI with one decimal place using "bmi.toFixed(1)" method

Your calculation is correct, but read carefully what the task is asking for. It says
It should return their Body Mass Index to 1 decimal place

Is that what your function does? You are returning a string here.

Oh, I see. I got overly enthusiastic with the result, when only bmi number is expected.
Thank you for pointing that out.

Refactor formatAs12HourClock function to improve readability and fix output format. Adjust test cases to match expected output format without spaces.

LonMcGregor · 2026-07-07T15:11:12Z

Good work on the time task - it is done now. See my earlier comment about the BMI calc.

Updated the calculateBMI function to return only the BMI value with one decimal place instead of a full message.

LonMcGregor

Correct. Typically a function will do one task, and a different function will handle presentation

vmoratti added 26 commits June 10, 2026 19:36

add comment explaining what like 3 is doing

72a2114

use string indexing to get the initials

e988493

figure out what (num) represents, add comment

541c57c

solve the slicing proble,create dir variabe and ext variable

2c05e7e

answer the question in the exercse

0a2e2ac

change const to let, add comment

697ddfc

fix the error, comment on it

704b717

add question in comments

4c49b91

fix problem

6003611

answer all the questions in the exercise

06ed7a8

Answer questions in the exercise

a6d738a

add comments to explain code

c00ebcd

can't undestand instructions

c89d0c3

answer questions in objects.md

c1f0514

solve the code error message

71235b3

fix proble, answer questions

fa98548

fix code, explain fix

4b743c8

fix code, write explanation

4919640

explain and fix code

6a9bf82

explain and fix the code

9560e8d

create function to calculate BMI

6187040

implement function for UPPER_SNAKE

82a2abd

implement function to convert to pounds

ca2e82e

Answer questions

c81c5df

write tests, fix bugs

301c8f1

edit comment

9ccd193

This comment has been minimized.

Sign in to view

vmoratti added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Jun 30, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026

vmoratti added 9 commits June 30, 2026 21:43

Delete Sprint-1/1-key-exercises/2-initials.js

e042ab7

Delete Sprint-1/1-key-exercises/3-paths.js

19f6b35

Delete Sprint-1/1-key-exercises/4-random.js

2c2aeee

Delete Sprint-1/2-mandatory-errors/1.js

d43c9fa

Delete Sprint-1/2-mandatory-errors/0.js

b68e8ad

Delete Sprint-1/2-mandatory-errors/3.js

712fb63

Delete Sprint-1/3-mandatory-interpret/1-percentage-change.js

c10a299

Delete Sprint-1/3-mandatory-interpret/2-time-format.js

5a6b4c4

Delete Sprint-1/3-mandatory-interpret/3-to-pounds.js

8ccb9f5

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026

fix sprint-1 files

705c3e2

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026

LonMcGregor reviewed Jul 6, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026

vmoratti added 2 commits July 6, 2026 19:07

Fix comment formatting in calculateBMI function

c56be30

Refactor time formatting and update test cases

6fedd2a

Refactor formatAs12HourClock function to improve readability and fix output format. Adjust test cases to match expected output format without spaces.

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 7, 2026

Modify calculateBMI to return only BMI value

1b5fc8a

Updated the calculateBMI function to return only the BMI value with one decimal place instead of a full message.

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 7, 2026

LonMcGregor reviewed Jul 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | 26-ITP_May | Vito Moratti | Sprint 2 | Coursework/sprint 2#1429

London | 26-ITP_May | Vito Moratti | Sprint 2 | Coursework/sprint 2#1429
vmoratti wants to merge 44 commits into
CodeYourFuture:mainfrom
vmoratti:coursework/sprint-2

vmoratti commented Jun 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

LonMcGregor left a comment

Uh oh!

LonMcGregor Jul 6, 2026

Uh oh!

vmoratti Jul 6, 2026

Uh oh!

LonMcGregor Jul 7, 2026

Uh oh!

vmoratti Jul 7, 2026

Uh oh!

Uh oh!

Uh oh!

LonMcGregor commented Jul 7, 2026

Uh oh!

LonMcGregor left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

vmoratti commented Jun 30, 2026

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

vmoratti Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

vmoratti Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LonMcGregor commented Jul 7, 2026

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants