London | 26-ITP-May | Chun Yan Wong | Sprint 1 | CourseWork#1466
Open
cywong-dev wants to merge 14 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 1 | CourseWork#1466cywong-dev wants to merge 14 commits into
cywong-dev wants to merge 14 commits into
Conversation
Added comment explaining the increment operation on the count variable.
Initialize dir and ext variables to extract directory and file extension from filePath.
[ChunYanWong] Added comment explaining num as a random integer.
Updated last4Digits assignment to correctly extract the last 4 digits of cardNumber.
Added comments to clarify variable declarations, function calls, and expressions related to movie length.
Added comments to explain the purpose of each step in the code.
Clarify the effects and return values of alert and prompt functions.
Added syntax help for console.log and console.
This comment has been minimized.
This comment has been minimized.
cywong-dev
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
cywong-dev
added
Needs Review
cjyuan
reviewed
Jul 7, 2026
| // https://www.google.com/search?q=get+first+character+of+string+mdn | ||
|
|
||
| // added by ChunYanWong for the solution | ||
| initials = firstName.substring(0,1) + middleName.substring(0,1) + lastName.substring(0,1); |
Contributor
There was a problem hiding this comment.
There is a much shorter syntax to get the first character (or any character by its index) of a string.
|
|
||
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.substring(0, url.lastIndexOf("/") + 1);; |
Contributor
There was a problem hiding this comment.
-
What is
url? -
Should "dir" contain a trailing
/?
| // [ChunYanWong] The slice method extract substring starting with the first parameter position | ||
| // There is no -4 starting position and hence it will not work | ||
|
|
||
| const last4Digits = cardNumber.slice(cardNumber.length - 4) |
Contributor
There was a problem hiding this comment.
Did you execute the code to ensure it works as expected?
Comment on lines
+1
to
+2
| const twelveHourClockTime = "8:53pm"; | ||
| const twentyhourClockTime = "20:53"; |
Contributor
There was a problem hiding this comment.
It's a not a good idea to have two almost identical variable names. Besides, the second name is not quite in "lower camel case" format. Could you rename the variable(s)?
| //[ChunYanWong] 3 . They are Number, replaceAll and console.log | ||
|
|
||
| // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem? | ||
| // [ChunYanWong] syntax error - add the comma to fix it. |
Contributor
There was a problem hiding this comment.
We could more precisely describe "A comma is missing between "," and "" in the function call" as:
A comma is missing between the ___________s.
What is this programming term that refers to the values passed to a function? It begins with an 'a'.
Comment on lines
23
to
+25
| What is the return value of `prompt`? | ||
|
|
||
| [ChunYanWobg] Inputted name |
Contributor
There was a problem hiding this comment.
What if a user enters a name and clicks "Cancel" instead of "OK"?
Comment on lines
23
to
+25
| What does the syntax `console.log` or `console.assert` mean? In particular, what does the `.` mean? | ||
|
|
||
| [ChunYanWong] The method of the object console or the functions of the object console |
Contributor
There was a problem hiding this comment.
The last question had a second part. Could you also answer that?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide
Changelist
Complete the coursework for sprint 1 in the module Structuring and testing data